fix: remove explicit connection_pool dependency to allow 3.x - #394
Merged
Conversation
Removes the explicit connection_pool ~> 2.4 runtime dependency that was preventing use of connection_pool 3.x (required by sidekiq 8.1+). The gem is already managed as a transitive dependency by net-http-persistent 4.0.8, which supports connection_pool >= 2.2.4, < 4. Since we don't directly use connection_pool's API, there's no need to declare it explicitly. Fixes #393
Contributor
|
FWIW, there is still the ugly timeout hack that reaches into the connection pool's internals, and is more likely to break between major versions. @nhp = Net::HTTP::Persistent.new(name: "vault-ruby", pool_size:)
@nhp.pool.instance_variable_set(:@timeout, pool_timeout)That doesn't need to block this PR... but it might be worth converting that into an upstream PR (or two). |
Contributor
|
Related, dependabot can be configured to "widen" the gem deps. That should be able to automatically create PRs like this: - spec.add_runtime_dependency "connection_pool", "~> 2.4"
+ spec.add_runtime_dependency "connection_pool", ">= 2.4, < 4"(Obviously, it'd be better to simply remove the direct dep on connection_pool internals!) |
|
🥇 |
amy-hashi
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the explicit connection_pool ~> 2.4 runtime dependency that was preventing use of connection_pool 3.x (required by sidekiq 8.1+).
The gem is already managed as a transitive dependency by net-http-persistent 4.0.8, which supports connection_pool >= 2.2.4, < 4. Since we don't directly use connection_pool's API, there's no need to declare it explicitly.
Fixes #393